search

njouanin / hbmqtt

MQTT client/broker using Python asynchronous I/O
MIT License
795 stars 188 forks source link

Replace formatted string with c-style #229

Closed HerrMuellerluedenscheid closed 3 years ago

HerrMuellerluedenscheid commented 3 years ago

f-strings have been introduced in python3.6. If hbmqtt should still comply py3.5 it needs to use classic c-style. However, I personally think it would be very reasonable to drop python3.5 support. What do you think @njouanin?

HerrMuellerluedenscheid commented 3 years ago

python3.5 is not supported anymore by pip and does not receive security patches anymore. Thus, instead of falling back to c-style string formatting, we can also deprecate python3.5. I personally think, this is the better option. Opinions?

FlorianLudwig commented 3 years ago

@HerrMuellerluedenscheid

As we dropped python3.5 in aMQTT , would you still like to merge this?

HerrMuellerluedenscheid commented 3 years ago

This is deprecated with respect to the progress on https://github.com/Yakifo/amqtt