search

njouanin / hbmqtt

MQTT client/broker using Python asynchronous I/O
MIT License
800 stars 188 forks source link

The future of hbmqtt? Is it still maintained or EOL? #235

Closed HerrMuellerluedenscheid closed 3 years ago

HerrMuellerluedenscheid commented 3 years ago

Hi @njouanin,

Are you still maintaining hbmqtt? I see very little activity from your side. I think hbmqtt is really a great library but it needs a little maintenance. If you do not have the capacity at the moment maybe you can let the community help you. It would be good if in that case you would add one or preferably two maintainers to this repo that can review, correct and merge critical PRs. Of course people can take over maintenance on some fork but it would be best if this repo (and pypi) would not change and remain the master.

Software that is not maintained usually dies quite quickly and I see hbmqtt on the verge here as it is really based on outdated python support. I can only repeat: hbmqtt is really great and it would be such a shame if it did not receive any patches.

So, let's try to find a suitable maintenance strategy. Best Marius

HerrMuellerluedenscheid commented 3 years ago

ping @njouanin

shipmints commented 3 years ago

https://github.com/M-o-a-T/distmqtt is a fork that's been updated a bit (and you have to prefer anyio vs. asyncio). However, a quick reading shows that it has the same issues as in #237 but if it is more likely to be repaired and to accept contributions it may be time to either fork hbmqtt itself with proposed changes and corrections (and with more comprehensive tests) or look at someone else's fork. I'd hate to abandon @njouanin after all the work put into hbmqtt, and he may have an interesting backlog of work and ideas. When hbmqtt is used with the features that are known to work, staying away from those that break ala #237, and using the most recent release that incorporates key fixes, it works fine for low message-rate applications. I value a pure-python implementation using as few extra dependencies as possible that is easy to reason about.

njouanin commented 3 years ago

Hi, I'm not maintaining this repo anymore. Please feel free to fork.

FlorianLudwig commented 3 years ago

@njouanin thank you for the heads-up.

Would you be willing to turn over the pypi package to a group of volunteers to maintain it?

HerrMuellerluedenscheid commented 3 years ago

Hi @njouanin, thanks for the info. good to know! I agree with @FlorianLudwig. It would save a lot of confusion and extra work to keep the pypi package maintained. Also, if people install unmaintained software can cause significant security risks. Me and a colleague would be happy to start a more community driven support for hbmqtt. Anybody else interested, feel free to drop a message.

shipmints commented 3 years ago

@HerrMuellerluedenscheid, I'll try to lend a hand.

shipmints commented 3 years ago

@HerrMuellerluedenscheid not sure how quickly you want to address this. Let me know. I suppose that until @njouanin helps with an ownership transition of the existing pypi package or we elect to replace it with a new one, this initiative will be stalled.

pavandv commented 3 years ago

@HerrMuellerluedenscheid count me in

FlorianLudwig commented 3 years ago

hbmqtt has been forked

The fork is called amqtt, github project here: https://github.com/Yakifo/amqtt

Changes include: