search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
98 stars 86 forks source link

Typo in hbar #106

Closed whaeck closed 6 years ago

whaeck commented 6 years ago

After refactoring the constants into the phys.f90 file, hbar (in erg) is defined as: real(kr),parameter,public::hbar=6.58219514e-16_kr*ev !Planck/2pi, erg

The numerical value has a missing digit in it, it should be: real(kr),parameter,public::hbar=6.582119514e-16_kr*ev !Planck/2pi, erg

E.g. see ENDF manual appendix H.

Be aware that this minor difference has an impact on the 4th or 5th significant digit of all cross section values coming out of NJOY and has been present in the code since 27 days. This will be fixed as soon as possible.

whaeck commented 6 years ago

Fixed in #107

whaeck commented 6 years ago

Additional typos were discovered for the electron and He3 (helion) mass values, reported by @kahlerac. These have been fixed in bugfix/constants.

whaeck commented 6 years ago

Fixed additional issues in #115