search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Fix/acer iza #127

Closed whaeck closed 4 years ago

whaeck commented 5 years ago

Proposed fix for issue #126, more information can be found in the issue description.

The meaning of awn still needs to be evaluated.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling 8a21b38ab9759602d97ce9fa8a1d16bb56120536 on fix/acer-iza into e778142e207b21573524a8097fb3a50ca26567a2 on master.

whaeck commented 4 years ago

Yeah, I was thinking about testing yesterday as well. I would need an input file for Zr in ZrH, since that one has more than three za to be set in the ACE file.

whaeck commented 4 years ago

@jlconlin @dkentp Ready for review

whaeck commented 4 years ago

@dkentp To clarify: whenever we do something like:

read(nsysi,*) (izn(i),i=1,nza)

the program will try to read as many values as it can, up until encountering '/' or when the total number of values has been read (potentially going onto the next line as necessary). Adding nza as an input parameter could alleviate some issues due to this but I don't think there will be major concerns (in most cases, users already set / at the end of that line to not have to write values for the second and/or third iza).