Fix/cpt - Githubissues

whaeck commented 5 years ago

A number of corrections to produce incident charged particle ACE files:

increasing an array size (for the number of Coulomb angles)
correcting issue #138 in all instances (ACER and GROUPR)

I'm still working on getting a few test files added for the different cases one may encounter:

MF6 MT2 LAW=5 LTP=1 (nuclear amplitude expansion)
MF6 MT2 LAW=5 LTP=2 (residual cross section expansion as Legendre coefficients)
MF6 MT2 LAW=5 LTP=12 (nuclear plus interference distribution with probabilities linear in mu)
MF6 MT2 LAW=5 LTP=14/15 (tabulation in loglin or linlin)

Still to be added as well: release notes

coveralls commented 5 years ago

Coverage remained the same at ?% when pulling 09789a8bc3bc1d6d9b186042b65a15d9a155e42e on fix/cpt into e40a0d0e09cdf347aa0eb18422754d0e6114cd96 on master.

whaeck commented 5 years ago

5 tests were added. As expected, only two of them changed from NJOY 2016.51 to 2016.52: the one for identical particles with spin = 0 and the one with spin = 1. The other tests (2 for different particles and one for identical particles with a half integer spin) did not change, as expected.

Release notes and test descriptions were added.

This one is good to go.

jlconlin commented 5 years ago

By the way, all the tests passed without the updated fortran files.

njoy / NJOY2016

Fix/cpt #139