njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Raised THERMR Emax upper Limit from 10eV to 100eV #157

Open yunhuangzhang opened 4 years ago

yunhuangzhang commented 4 years ago

We found that the internal limit of Emax<=10eV prevented us from obtaining accurate neutron slowing-down calculations (for instance, in Borated HDPE) in the thermal range. Free-gas and S(\alpha,\beta) treatment were both affected. The initial findings with numerical experiments were documented in our M&C2017 conference paper "NJOY Maximum Energy Limit For Thermal Neutron". A journal article with more in-depth proof based on two-body kinematic analyses is currently under review (2rd round) with Progress in Nuclear Energy.

Raising Emax was achieved by adding energy grid points, which were initially proposed by Dr. A. C. (Skip) Kahler. Raising Emax to 100eV resulted in satisfactory numerical simulations compared to experiments, and we think it should be adequate for most other applications as well. This limit can be further lifted by extending the grid but should be used with caution.

jlconlin commented 4 years ago

Thank you @yunhuangzhang for your Pull Request. This is a fairly straightforward change to the code, but I'm not sure about it's physical relevance.

I'm no expert on thermal scattering, but it seems that 100 eV is much higher than what is reasonable for the thermal scattering treatment. There are a few NJOY contributors (@marquezj, @vedantkm, and @ameliajo) who—gratefully—have helped with these issues in the past. Hopefully they won't mind chiming in on this.

To help us better judge the validity of the physics, can you please attach your M&C paper? I know the other paper is still under review, but we need to have something to review before we can understand the right thing to do.

jlconlin commented 4 years ago

Hah, I just realized that I already had the M&C paper. I've attached it here as a reference. MC2017_NJOY_Full.pdf

yunhuangzhang commented 4 years ago

Thank you @jlconlin for your quick response. Besides the M&C paper, you can find the article preprint on my RG homepage, where we used analytic model to justify the need for an increase emax.

The bottom line is, extending beyond the current energy grid does not change any aspect of the code behavior for emax<=10eV. And there are situations where a simulation can benefit from an increased emax.

It actually took us months to pinpoint the source for the discrepancy found in your slowing-down calculations (presented in both paper). We hope this little contribution can save others some headache should they run into the similar problems.

jchsublet commented 4 years ago

A word of caution, as I remember when we pushed the limit from 4 to 10 eV, thermal scattering belongs to molecular physics and if I could see advantages to push higher for dedicated material in special circumstance I would advice not to rock the boat for reactor physics H in H20 or O in H2O or even O in Pu02, when the s(a,b) mixes with the nuclear fuel first resonances and the beginning of self-shielding in deterministic simulation. Anyway one always can model more than one same material in different regions in simulation: e.g. H in Poly (could be up 100 eV) but O in Pu02 (better be below 10 eV) a sage precaution

marquezj commented 4 years ago

From what I see, the problem is not THERMR itself, but that multigroup codes failback to target-at-rest kinematics when they do not have thermal data. MCNP on the other hand has S(alpha,beta) + free gas at Teff (provided by THERMR + ACER) below a cutoff energy, and free gas at T above the cutoff energy.

Extending the incident energy grid in THERMR should not be a problem, but if it is used for materials other than hydrogen care must be taken not to affect resonances.

@yunhuangzhang did you test this with materials with a coherent-elastic component (graphite, beryllium)? GROUPR has a hard coded limit of 10 eV for Bragg-edge treatment and might complicate things.

yunhuangzhang commented 4 years ago

I totally agree with @jchsublet and @marquezj. Current the two-body model presented in our paper is only based on free-gas hydrogen. Therefore one should be very cautious when applying it to other more sophisticated materials. And yes, a much higher thermal cut-off is not advisable for heavier nuclides due to interference with resonances. As a matter of fact, for those isotopes free-gas treatment has very limited impact on their thermal scattering, and the original 10eV is more than adequate for most cases.

To be more specific: the proposed fix was verified with H free-gas using the back-to-basic two-body model, and similar trend was also observed from numerical experiment with H poly. I would not advise people to use 100eV as default when dealing with other materials. But it is nice to have the flexibility if one is dealing with H free-gas or H poly.

yunhuangzhang commented 4 years ago

@yunhuangzhang did you test this with materials with a coherent-elastic component (graphite, beryllium)? GROUPR has a hard coded limit of 10 eV for Bragg-edge treatment and might complicate things.

@marquezj No we haven't. We didn't experiment the higher emax with graphite or beyllium, neither did we do any theoretical analyses on them. In our experiments, we only used 100eV emax for the H fg and H poly, and used lower emax for other materials.

yunhuangzhang commented 4 years ago

FYI, the paper was accepted and now available online.

Analytic evaluation of hydrogen neutron elastic scattering moments with free-gas thermal treatment compared to NJOY .pdf