search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Feature/upn epm #160

Closed kahlerac closed 4 years ago

kahlerac commented 4 years ago

Adding, and changing some existing, group identifiers in ERRORR and GROUPR. Share code for uniform group labels in both GROUPR and ERRORR.

@jchsublet Will this affect your legacy NJOY2012 inputs? We're changing group numbers from the local upn created for the Agency several years ago.

jlconlin commented 4 years ago

PS. I've run the tests on my machine and they all pass. Let's wait and see what GitHub Actions reports.

jchsublet commented 4 years ago

@wim @jlconlin @kahlerac Groups identifiers are extremely important in groupr, why they differs in errorr is for me a mystery, errorr should have a subset, and only a subset with the same read in id. GROUPR is thousand times more important than errorr for useful applications, if you insist to change ERRORR logic do in such a way that it correspond to GROUPR, the influence it will have on legacy input will be minimal and to be honest errorr and errors users are not legion.