search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Reference outputs are not used during make test #171

Closed vivian-salino closed 4 years ago

vivian-salino commented 4 years ago

Hello, everybody,

I am very intrigued by the fact that obtained outputs and reference outputs are not compared during make test. This surprising fact can be reproduced very simply by running the test battery without error with the following commands:

cd NJOY2016
cmake .
make
cd tests
rm -f */referenceOutput
make test

Maybe is it on purpose? But if so, why are the reference outputs kept at all?

whaeck commented 4 years ago

Salut Vivian

You are correct, the outputs are not used in the tests, only tapes are compared. You'll see that in the more recent tests that we've added over the years, none of the outputs are saved.

We probably should clean up those outputs at some point but it's not really a pressing issue.

Best regards, Wim

vivian-salino commented 4 years ago

Merci Wim !

Bonne journée et au plaisir 😃