njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Fix/cpt #172

Closed whaeck closed 4 years ago

whaeck commented 4 years ago

Fixing an array overflow following NaNs in a charged particle ACE file.

I'm waiting on a response from Mark Paris to see if we can add a test case based on the evaluation (if we can, I'll also make an issue out of it).

kahlerac commented 4 years ago

This works, so I approve. But, "ne" is passed to acecpe so why not make xxs and yys allocatable to the needed size and avoid having to test for an array overflow?

whaeck commented 4 years ago

@kahlerac Good point, I looked for where ne came from but I seemed to have overlooked it in the function signature. Making the arrays allocatable and set to a size of ne is probably the best things to do.