search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Updated Python version to 3.5 minimum #185

Closed whaeck closed 3 years ago

whaeck commented 3 years ago

isclose is only available starting from Python 3.5. These changes impose the minimum version 3.5 for the python interpreter.

Since Python2 is no longer officially supported, we make the choice of imposing Python 3.5 as the minimum requirement - even though NJOY2016 does not use python during execution.

jlconlin commented 3 years ago

I'm glad you caught this. It does need to be updated. I just wonder why you removed the code to throw an error when Python3 isn't found.

jlconlin commented 3 years ago

Don't forget to update the ReleaseNotes.

whaeck commented 3 years ago

@jlconlin I don't see the issue with execute.py, so I think we're good

jlconlin commented 3 years ago

I'm good as soon as the ReleaseNotes are updated. We didn't so anything for the physical constants so that should be done.

whaeck commented 3 years ago

You did update ReleaseNotes.md, I'm looking at it right now. Or is there something else you want to add?

jlconlin commented 3 years ago

You did update ReleaseNotes.md, I'm looking at it right now. Or is there something else you want to add?

Yeah. Can you update my brain because I forgot I updated the release notes? 🤦🏻

jchsublet commented 3 years ago

With this branch fix/python3.5 NJOY2016.61 make test now works properly, seamlessly and successfully. It was never about the compilation that was fully successful and functional but only the test suite sequence. Test on OsX 10.14 Mojave/ gfortran 8.3.0.