njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

Fix/endf80 mf34 #206

Closed whaeck closed 3 years ago

whaeck commented 3 years ago

Fixing issues #122 and #203.

We're merging this into develop instead of master since the fix is "incomplete": NJOY2016 no longer crashes on U235 from ENDF/B-VIII.0 for MF34 covariance data but we still need to fix covout. The remaining issue is detailed in #205.

@kahlerac this is a simple one, so I'm giving it to you for review. We should schedule a phone call to see if you could help out on issue #205 - I'd do it myself but I'm overcommitted as it is.

whaeck commented 3 years ago

@kahlerac Thanks. About the LCT value, I was wondering about that one myself - as to why it was not being used. It might be that LCT was always set to the same value and that Bob did not bother with adding a treatment depending on LCT.

I'll merge this, and we can debate the LCT value for the next merge on this topic.