Fix/cp33 - Githubissues

njoy / NJOY2016

Nuclear data processing with legacy NJOY

https://www.njoy21.io/NJOY2016

Other

96 stars 86 forks source link

Fix/cp33 #215

Closed whaeck closed 3 years ago

whaeck commented 3 years ago

This fixes issue #212

Some more ACELAW=33 shenanigans:

the partial probability for ACELAW=33 to occur is not properly set to E0, E1, P0, P1 instead of E0, P0, E1, P1
a correction for the values stored for ACELAW=33

enorrislanl commented 3 years ago

Looks good to me. It appears that we're effectively replacing the current MT=102 ACELAW=33 behavior with proper 2-body kinematics. Since the equations we're using are (I think) only really valid when the mass of both products is non-zero there may be an even better approach if we give it enough thought, but this is certainly better than the current behavior.

whaeck commented 3 years ago

@enorrislanl Thanks for looking into this, I'm going to quickly check the photonuclear data to see if ACELAW=33 is used there as well before I merge this in.

whaeck commented 3 years ago

@enorrislanl We're good to go on this one. Had some further issues with tests but now we're good.