search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
98 stars 86 forks source link

Unable to compile using GCC 11 #230

Closed kermitnuc closed 2 years ago

kermitnuc commented 2 years ago

I got this error today using GCC 11 on a MacBook Pro running OsX 12.2.1

[ 28%] Building Fortran object _deps/njoy-build/CMakeFiles/njoy.dir/src/errorr.f90.o f951: internal compiler error: Segmentation fault: 11 Please submit a full bug report, with preprocessed source if appropriate. See https://github.com/Homebrew/homebrew-core/issues for instructions. make[2]: [_deps/njoy-build/CMakeFiles/njoy.dir/build.make:239: _deps/njoy-build/CMakeFiles/njoy.dir/src/errorr.f90.o] Error 1 make[1]: [CMakeFiles/Makefile2:2603: _deps/njoy-build/CMakeFiles/njoy.dir/all] Error 2 make: *** [Makefile:161: all] Error 2

This same error was reported on the HomeBrew site last July.

Kermit Bunde

whaeck commented 2 years ago

The underlying problem is in NJOY2016 so I transferred this to the NJOY2016 repository.

The issue is already described in #211

While gcc (and gfortran in particular) has always worked for NJOY2016 compilation (it is my default compiler), gcc-11 seems to have introduced an issue that causes the compiler to fail. It seems to happen in the ERRORR coding but I have not been able to track it down just yet.

Do you have the possibility to downgrade to a different version of gcc? Tests have shown that any gcc version between 7 up to and including 10 can compile NJOY2016. We have not tested gcc-12 yet but we will do that soon.

kermitnuc commented 2 years ago

That is the same issue I found. Sorry I did not see this issue in the big report. I was using GCC11. I tried GCC10. It works although it is for Big Sur. I upgraded to Monterey a bit ago.

Kermit

Sent from my iPhone

On Mar 7, 2022, at 9:45 AM, Wim Haeck @.***> wrote:

 The underlying problem is in NJOY2016 so I transferred this to the NJOY2016 repository.

The issue is already described in #211

While gcc (and gfortran in particular) has always worked for NJOY2016 compilation (it is my default compiler), gcc-11 seems to have introduced an issue that causes the compiler to fail. It seems to happen in the ERRORR coding but I have not been able to track it down just yet.

Do you have the possibility to downgrade to a different version of gcc? Tests have shown that any gcc version between 7 up to and including 10 can compile NJOY2016. We have not tested gcc-12 yet but we will do that soon.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

whaeck commented 2 years ago

Great. At least you can compile NJOY with another compiler. Since this is an internal compiler error, it is a lot more difficult for me to figure out where the issue is. At least we know it is in ERRORR.

I'm closing the issue since already track it in #211 - although it is always a good thing to poke us for us to try and do something about it ;-)

Best regards, Wim

kermitnuc commented 2 years ago

I will see what I can come up with tomorrow.

Kermit

Sent from my iPhone

On Mar 7, 2022, at 10:13 AM, Wim Haeck @.***> wrote:

 Great. At least you can compile NJOY with another compiler. Since this is an internal compiler error, it is a lot more difficult for me to figure out where the issue is. At least we know it is in ERRORR.

I'm closing the issue since already track it in #211 - although it is always a good thing to poke us for us to try and do something about it ;-)

Best regards, Wim

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

kermitnuc commented 2 years ago

The problem is somewhere in the covout subroutine.

Kermit

On Mar 7, 2022, at 10:13 AM, Wim Haeck @.***> wrote:

Great. At least you can compile NJOY with another compiler. Since this is an internal compiler error, it is a lot more difficult for me to figure out where the issue is. At least we know it is in ERRORR.

I'm closing the issue since already track it in #211 https://github.com/njoy/NJOY2016/issues/211 - although it is always a good thing to poke us for us to try and do something about it ;-)

Best regards, Wim

— Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/230#issuecomment-1060924068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6KJ4THU6TWO2DRL3MIKNLU6Y2LRANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

whaeck commented 2 years ago

Yes, I have been looking at this more closely and I've come to the same conclusion. It is just a weird problem, as you can see in the comments I put in the original issue: https://github.com/njoy/NJOY2016/issues/211#issuecomment-1061153805

I'm going to try and install gcc-12 to see if the problem persists in that version. If it does, I'll put in a gcc bug report.

Best regards,

Wim

From: kermitnuc @.***> Sent: Tuesday, March 8, 2022 12:39:30 PM To: njoy/NJOY2016 Cc: Haeck, Wim; State change Subject: [EXTERNAL] Re: [njoy/NJOY2016] Unable to compile using GCC 11 (Issue #230)

The problem is somewhere in the covout subroutine.

Kermit

On Mar 7, 2022, at 10:13 AM, Wim Haeck @.***> wrote:

Great. At least you can compile NJOY with another compiler. Since this is an internal compiler error, it is a lot more difficult for me to figure out where the issue is. At least we know it is in ERRORR.

I'm closing the issue since already track it in #211 https://github.com/njoy/NJOY2016/issues/211 - although it is always a good thing to poke us for us to try and do something about it ;-)

Best regards, Wim

— Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/230#issuecomment-1060924068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6KJ4THU6TWO2DRL3MIKNLU6Y2LRANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHubhttps://github.com/njoy/NJOY2016/issues/230#issuecomment-1062134581, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AENOHQDVJN2AFIACETDMHNTU66UHFANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you modified the open/close state.Message ID: @.***>

kermitnuc commented 2 years ago

In looking a bit more:

taking out these two lines allows the ERRORR to compile.

  else if (irespr.eq.1) then
     call resprx(nwds,scr)

On Mar 8, 2022, at 12:52 PM, Wim Haeck @.***> wrote:

Yes, I have been looking at this more closely and I've come to the same conclusion. It is just a weird problem, as you can see in the comments I put in the original issue: https://github.com/njoy/NJOY2016/issues/211#issuecomment-1061153805

I'm going to try and install gcc-12 to see if the problem persists in that version. If it does, I'll put in a gcc bug report.

Best regards,

Wim

From: kermitnuc @.***> Sent: Tuesday, March 8, 2022 12:39:30 PM To: njoy/NJOY2016 Cc: Haeck, Wim; State change Subject: [EXTERNAL] Re: [njoy/NJOY2016] Unable to compile using GCC 11 (Issue #230)

The problem is somewhere in the covout subroutine.

Kermit

On Mar 7, 2022, at 10:13 AM, Wim Haeck @.***> wrote:

Great. At least you can compile NJOY with another compiler. Since this is an internal compiler error, it is a lot more difficult for me to figure out where the issue is. At least we know it is in ERRORR.

I'm closing the issue since already track it in #211 https://github.com/njoy/NJOY2016/issues/211 - although it is always a good thing to poke us for us to try and do something about it ;-)

Best regards, Wim

— Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/230#issuecomment-1060924068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6KJ4THU6TWO2DRL3MIKNLU6Y2LRANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHubhttps://github.com/njoy/NJOY2016/issues/230#issuecomment-1062134581, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AENOHQDVJN2AFIACETDMHNTU66UHFANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you modified the open/close state.Message ID: @.***> — Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/230#issuecomment-1062144868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6KJ4TLPFBW5D4J76GV2HTU66VWTANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

kermitnuc commented 2 years ago

Wim,

I looked at the writeup. What I found is that just deleting this section:

     !--Unresolved
     if (lru.eq.2) then
        call rpxunr(a,amur,mxlru2,iest,ieed,nwscr)

     !--Resolved with sammy method
     else if (nmtres.gt.0) then
        call rpxsamm(nwscr,a,ier)

     !--Resolved with errorj method
     else
        if (lcomp.eq.0) then
           call rpxlc0(nwscr,a)
        else if (lcomp.eq.1.or.lcomp.eq.2) then
           call rpxlc12(nwscr,a,iest,ieed)
        endif
     endif

Allowed the GFORTRAN 11.2 complier to compile the program. I did not have to delete any other subroutine calls.

Kermit

On Mar 8, 2022, at 3:43 PM, Kermit Bunde-google @.***> wrote:

In looking a bit more:

taking out these two lines allows the ERRORR to compile.

  else if (irespr.eq.1) then
     call resprx(nwds,scr)

On Mar 8, 2022, at 12:52 PM, Wim Haeck @. @.>> wrote:

Yes, I have been looking at this more closely and I've come to the same conclusion. It is just a weird problem, as you can see in the comments I put in the original issue: https://github.com/njoy/NJOY2016/issues/211#issuecomment-1061153805 https://github.com/njoy/NJOY2016/issues/211#issuecomment-1061153805

I'm going to try and install gcc-12 to see if the problem persists in that version. If it does, I'll put in a gcc bug report.

Best regards,

Wim

From: kermitnuc @.***> Sent: Tuesday, March 8, 2022 12:39:30 PM To: njoy/NJOY2016 Cc: Haeck, Wim; State change Subject: [EXTERNAL] Re: [njoy/NJOY2016] Unable to compile using GCC 11 (Issue #230)

The problem is somewhere in the covout subroutine.

Kermit

On Mar 7, 2022, at 10:13 AM, Wim Haeck @.***> wrote:

Great. At least you can compile NJOY with another compiler. Since this is an internal compiler error, it is a lot more difficult for me to figure out where the issue is. At least we know it is in ERRORR.

I'm closing the issue since already track it in #211 <https://github.com/njoy/NJOY2016/issues/211 https://github.com/njoy/NJOY2016/issues/211> - although it is always a good thing to poke us for us to try and do something about it ;-)

Best regards, Wim

— Reply to this email directly, view it on GitHub <https://github.com/njoy/NJOY2016/issues/230#issuecomment-1060924068 https://github.com/njoy/NJOY2016/issues/230#issuecomment-1060924068>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR6KJ4THU6TWO2DRL3MIKNLU6Y2LRANCNFSM5QDYJJ4A https://github.com/notifications/unsubscribe-auth/AR6KJ4THU6TWO2DRL3MIKNLU6Y2LRANCNFSM5QDYJJ4A>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub<https://github.com/njoy/NJOY2016/issues/230#issuecomment-1062134581 https://github.com/njoy/NJOY2016/issues/230#issuecomment-1062134581>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AENOHQDVJN2AFIACETDMHNTU66UHFANCNFSM5QDYJJ4A https://github.com/notifications/unsubscribe-auth/AENOHQDVJN2AFIACETDMHNTU66UHFANCNFSM5QDYJJ4A>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you modified the open/close state.Message ID: @.***> — Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/230#issuecomment-1062144868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR6KJ4TLPFBW5D4J76GV2HTU66VWTANCNFSM5QDYJJ4A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.