search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
95 stars 82 forks source link

NJOY package for conda-forge? #240

Closed paulromano closed 2 years ago

paulromano commented 2 years ago

@whaeck @nathangibson14 As you know, OpenMC relies on NJOY for generating ACE files, which are then converted into our own HDF5 format, so NJOY is essentially an optional dependency for OpenMC. We have a conda-forge package for OpenMC that is popular with users, but when they install from there they don't get NJOY automatically. I'd like to setup a conda-forge package for NJOY so that I can list that as runtime dependency for OpenMC, which means anyone installing OpenMC from conda-forge would automatically get NJOY as well. Before I do that though, I wanted to check with you guys to make sure you're OK with it. In particular, I would probably base the package off NJOY2016 rather than NJOY21 since NJOY2016 continues to be the "production" version, as best as I can tell.

nathangibson14 commented 2 years ago

Hey @paulromano, NJOY2016 is indeed the easier option to use right now, and there are no practical differences between the two with regards to processing. So agreed, NJOY2016 makes sense.

No qualms with the conda-forge package for your purposes. If we pursue deployment with those sorts of utilities on our side later, we can revisit, but we don't have anything in the works right now.

kkiesling commented 2 years ago

Excellent- I will get started on a conda forge recipe and post it here when I have something that works and/or the conda-forge PR open. I will probably reach out again to get a list of people who want to be maintainers too.

kkiesling commented 2 years ago

I have the start of a conda forge package ready here. When this is merged by conda-forge, our feedstock will be available.

@nathangibson14 or any other developers- would you like me to add you as a maintainer for the conda-forge feedstock?

nathangibson14 commented 2 years ago

Probably best to add both @whaeck and me. Thanks!

-- Nathan A. Gibson Staff Scientist, XCP-5 Nuclear Data Team ASC-PEM-Nuclear Physics Project Leader Los Alamos National Laboratory o. (505) 665-2338 | c. (505) 629-8409

From: Kalin Kiesling @.> Reply-To: njoy/NJOY2016 @.> Date: Friday, April 1, 2022 at 3:28 PM To: njoy/NJOY2016 @.> Cc: "Gibson, Nathan Andrew" @.>, Mention @.***> Subject: [EXTERNAL] Re: [njoy/NJOY2016] NJOY package for conda-forge? (Issue #240)

I have the start of a conda forge package ready herehttps://urldefense.com/v3/__https:/github.com/conda-forge/staged-recipes/pull/18547__;!!Bt8fGhp8LhKGRg!X-QaTVh-Ok4AT7QjtpD5N_84ROcKAfS5v10odt0-8MlGOUO_ApEn-MUrtThpacA$. When this is merged by conda-forge, our feedstock will be available.

@nathangibson14https://urldefense.com/v3/__https:/github.com/nathangibson14__;!!Bt8fGhp8LhKGRg!X-QaTVh-Ok4AT7QjtpD5N_84ROcKAfS5v10odt0-8MlGOUO_ApEn-MUrlDbasWc$ or any other developers- would you like me to add you as a maintainer for the conda-forge feedstock?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/njoy/NJOY2016/issues/240*issuecomment-1086339966__;Iw!!Bt8fGhp8LhKGRg!X-QaTVh-Ok4AT7QjtpD5N_84ROcKAfS5v10odt0-8MlGOUO_ApEn-MUrpppIQBA$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AAK6KQ2KQ63WHRLL77VCI63VC5S6DANCNFSM5RSLYIJQ__;!!Bt8fGhp8LhKGRg!X-QaTVh-Ok4AT7QjtpD5N_84ROcKAfS5v10odt0-8MlGOUO_ApEn-MUrhO3LzoU$. You are receiving this because you were mentioned.Message ID: @.***>

kkiesling commented 2 years ago

@nathangibson14 and @whaeck - not sure if you saw my comment on the conda forge PR here, but you will both need to consent via comment on that PR to being maintainers before the conda forge package can be accepted.

kkiesling commented 2 years ago

NJOY2016 has officially been added to conda forge! 🎉

So this issue can probably be closed now (I don't have permission to close).