search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
96 stars 86 forks source link

GROUPR does not produce gammas from fission for E8R0 U235, U238, Pu239 #265

Open wempleca opened 2 years ago

wempleca commented 2 years ago

Separate from previous GROUPR gamma production issue. The new MF6 format (multiple subsections) is skipped in GROUPR; this is the selected format for MT18 in the fissionable CIELO nuclides (U235, U238, Pu239). Additionally, the average photon distribution data in MF12/14/15 is not processed, so no photons are produced by fission reactions. Not having emitted photons from fission makes it impossible to create a coupled multigroup neutron-gamma library.

Input and output from NJOY-2016 for U235 attached.

U235.njoy.inp.txt U235.njoy.out.txt

kahlerac commented 2 years ago

Hi Chuck, Still things to be looked into wrt your issue, but I'm getting very different output with "my" NJOY2016.67 version for your 7N14, 24Cr50 and 92U235 jobs, which are attached here for your review. A couple of obvious differences are the vday date in NJOY's header and a different write format for some of the RECONR output. Are these from local changes you've made? And are there any others that have had unexpected side-effects? It might be informative to perform a "diff" on our respective NJOY2016.67 src folders. Skip

On Tue, Sep 27, 2022 at 2:48 PM wempleca @.***> wrote:

Separate from previous GROUPR gamma production issue. The new MF6 format (multiple subsections) is skipped in GROUPR; this is the selected format for MT18 in the fissionable CIELO nuclides (U235, U238, Pu239). Additionally, the average photon distribution data in MF12/14/15 is not processed, so no photons are produced by fission reactions. Not having emitted photons from fission makes it impossible to create a coupled multigroup neutron-gamma library.

Input and output from NJOY-2016 for U235 attached.

U235.njoy.inp.txt https://github.com/njoy/NJOY2016/files/9658762/U235.njoy.inp.txt U235.njoy.out.txt https://github.com/njoy/NJOY2016/files/9658763/U235.njoy.out.txt

— Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHJISMA42DO47DRBLS52BDWAM6PZANCNFSM6AAAAAAQXB55QU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Dr. A. C. (Skip) Kahler Kahler Nuclear Data Services, LLC @.*** +1 321 368 3645

wempleca commented 1 year ago

Hi Skip,

Thanks for checking on this. Your email made me go back through the (very minimal) modifications we have made in GROUPR.

TL;DR version:

  1. The "do while" loop at GROUPR.7139 should be modified, as it can generate an out-of-bounds array reference.
  2. My initial modification was flawed.

Full version:

We initially encountered problems with processing gamma production data for N-14 - the out-of-bounds array reference - which we caught because we build in DEBUG mode, rather than the standard mode. After a bit of digging into the evaluation and some analysis of the original coding, I made a modification to the aforementioned "do while" loop that, while syntactically correct, was flawed and, as I discovered yesterday, caused the loop to be exited prematurely. This resulted in some or all of the gamma production data to be not processed, resulting in the issue reports. We have since corrected the flawed coding and all seems to be working as expected.

The "do while" loop can generate the out-of-bounds array reference when econ is less than the lower energy bound of the photon group structure; this is not common (see the fairly short list in the first issue report), but occurs when the evaluator has included an emitted photon distribution at or near the end of File 12; many of these distributions extend down to zero photon energy. When igmin > ngg, problems develop if you build in DEBUG mode (it seems to power through if not checking array bounds). A fortunately easy problem to fix.

My runs since suggest that both issue reports may be closed, if the fix in GROUPR is implemented.

My sincere apologies for the resulting kerfuffle.

Best regards,

Chuck

[Logo Description automatically generated] Charles A. Wemple Senior Nuclear Engineer Studsvik Scandpower Inc.

+1 208 270 3351 1070 Riverwalk Dr., Suite #150 Idaho Falls, ID 83401 USA

From: Skip Kahler @.> Sent: Tuesday, September 27, 2022 1:06 PM To: njoy/NJOY2016 @.> Cc: Charles Wemple @.>; Author @.> Subject: Re: [njoy/NJOY2016] GROUPR does not produce gammas from fission for E8R0 U235, U238, Pu239 (Issue #265)

Hi Chuck, Still things to be looked into wrt your issue, but I'm getting very different output with "my" NJOY2016.67 version for your 7N14, 24Cr50 and 92U235 jobs, which are attached here for your review. A couple of obvious differences are the vday date in NJOY's header and a different write format for some of the RECONR output. Are these from local changes you've made? And are there any others that have had unexpected side-effects? It might be informative to perform a "diff" on our respective NJOY2016.67 src folders. Skip

On Tue, Sep 27, 2022 at 2:48 PM wempleca @.<mailto:@.>> wrote:

Separate from previous GROUPR gamma production issue. The new MF6 format (multiple subsections) is skipped in GROUPR; this is the selected format for MT18 in the fissionable CIELO nuclides (U235, U238, Pu239). Additionally, the average photon distribution data in MF12/14/15 is not processed, so no photons are produced by fission reactions. Not having emitted photons from fission makes it impossible to create a coupled multigroup neutron-gamma library.

Input and output from NJOY-2016 for U235 attached.

U235.njoy.inp.txt https://github.com/njoy/NJOY2016/files/9658762/U235.njoy.inp.txt U235.njoy.out.txt https://github.com/njoy/NJOY2016/files/9658763/U235.njoy.out.txt

- Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY2016/issues/265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHJISMA42DO47DRBLS52BDWAM6PZANCNFSM6AAAAAAQXB55QU . You are receiving this because you are subscribed to this thread.Message ID: @.<mailto:@.>>

-- Dr. A. C. (Skip) Kahler Kahler Nuclear Data Services, LLC @.<mailto:@.> +1 321 368 3645

- Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnjoy%2FNJOY2016%2Fissues%2F265%23issuecomment-1259932556&data=05%7C01%7Ccharles.wemple%40studsvik.com%7Ccf1acf17980e4370935308daa0bb5e9d%7C1b790d31b62c423ab9deba4d12ea718f%7C0%7C0%7C637999023851407346%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2J2Lbj%2BRK0qIGEN7NSjB7EJYvIUWIIUYppGChXjfv6s%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA26ASCAHBDQBZMPMFFF3PETWANAS5ANCNFSM6AAAAAAQXB55QU&data=05%7C01%7Ccharles.wemple%40studsvik.com%7Ccf1acf17980e4370935308daa0bb5e9d%7C1b790d31b62c423ab9deba4d12ea718f%7C0%7C0%7C637999023851407346%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HWakebk0KThA6yJO6gXb%2BqC9YRpOiy6Cjuo4LFPI3DA%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

The information contained in this email message, including any attachments, contains or may contain proprietary and confidential information intended only for the addressee. It is furnished with the understanding that it is for the sole use of the addressee and may only be used for the purposes for which it has been delivered by Studsvik or its designee. The information contained herein shall not be copied, reproduced or transmitted to any other parties, nor shall it be used for any other purpose, without prior written consent of Studsvik. If you have received this email in error, please return it to the sender and destroy or otherwise permanently delete the copy received.