search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
95 stars 82 forks source link

max number of photons issue in convr #290

Closed toshihikokawano closed 1 year ago

toshihikokawano commented 1 year ago

When the number of levels is N, then the max number of cascading photons is LMAX = N(N-1)/2. This may exceed the hard-coded number of 100.

whaeck commented 1 year ago

@toshihikokawano I changed the branch to merge into from master to develop. Develop contains the current release candidate for NJOY2016.70 which should be going into master by the end of March.

This is pretty straight forward so I'll merge this as soon as the tests complete. Is there a particular case that causes the error? I may want to just add that as a test case.

I'll update the release notes accordingly in a separate PR.

toshihikokawano commented 1 year ago

Recently we are putting all the discrete angular distributions and photons for charged particle channels in MT 600 - 850, and in some cases the number of photons reaches the max of 100. This happens to relatively light to medium mass nuclei. I will send an example by email.