search

njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
98 stars 86 forks source link

Fix/leapr array #320

Closed whaeck closed 1 year ago

whaeck commented 1 year ago

@HunterBelanger Everything looks good now. Tests pass so we're good to go. The failing tests must have been fixed in the last update you made.

HunterBelanger commented 1 year ago

Test 23 should have multiple temperatures in the LEAPR input. I believe that since Fortran 95, allocatable arrays are automatically deallocated when they go out of scope. I think this is why there are no deallocation statements at the end of contin. I didn't see any for the other arrays like p, tlast, tnow, and xa, so I didn't add one for maxt.

whaeck commented 1 year ago

Deallocation will be required when you run LEAPR multiple times in the same input deck. This is an issue we have seen in the past with other modules like ERRORR. In this case, I don't think it is necessary to protect users against themselves.

As such, I'll pull this into develop. If the deallocation comes up later, we'll just fix it then.