njoy / NJOY2016

Nuclear data processing with legacy NJOY
https://www.njoy21.io/NJOY2016
Other
95 stars 82 forks source link

Fix/euler #325

Closed whaeck closed 6 months ago

whaeck commented 6 months ago

An error was introduced so many years ago in the value of the Euler-Mascheroni constant when a number of physical constants were put in the phys.f90 file.

Luckily for us, the impact is limited. The constant is used in the calculation of the Coulomb wave functions - I think - so this will only be seen on nuclides that have charged particle channels in their resonance parameters (LRF=7 only). In the tests only test 20 is impacted as this is the only LRF=7 evaluation we use for our non-regression tests (again, I think). The elastic scattering and capture cross section only have a few values where the 6th digit after the decimal point is different. In MT103 and MT600 (the n,p reaction calculated from the resonance parameters), the impact is only really visible in low cross section values where the 4th to 6th digit after the decimal point are different. This is reflected in the few changes in the total cross section.

whaeck commented 6 months ago

I know. I verified it to see when it was introduced.