Binary gendf file crashes mf35 errorr run

[whaeck]

When using a binary gendf file coming out of groupr, errorr segfaults when processing the mf35 covariances:

Program received signal SIGSEGV: Segmentation fault - invalid memory reference. Backtrace for this error:

0 0x2b61f2e8926f in ???

1 0x2b61a12f220c in spcint

at /users/wim/NJOY2016/src/errorr.f90:2673

Segmentation fault

When using an ascii gendf file, there appears to be no issue at all. The following inputs illustrate the issue (the input endf tape is U235 from ENDF/B-VII.1): errorr-ascii.txt errorr-binary.txt

[whaeck]

The issue was traced back to a temporary array used when reading over the binary tape which apparently changed the number of groups from the actual value to another random value (probably because the array went over its allocated size of 17 values). By setting the size of this temporary array to 10000 instead of 17, the problem appears to go away but it is not clear why this issue only surfaces for binary tapes and not for ascii tapes.

The update has been put in the feature/errorr-endf8 branch.

[whaeck]

I will also create tests that test this issue, probably using another nuclide that takes less time in reconstruction and doppler broadening.

[whaeck]

This issue has been addressed in Pull request #81.