Can't build v1.1.0 using given instructions

njoy / NJOY21

NJOY for the 21st Century

https://www.njoy21.io/NJOY21

Other

74 stars 38 forks source link

Can't build v1.1.0 using given instructions #166

Open herter4171 opened 2 years ago

herter4171 commented 2 years ago

Based on the docs, what I've been doing is

git clone --branch v1.1.0 https://github.com/njoy/NJOY21.git
cd NJOY21
# No signature.json, so no metaconfigure.py
mkdir build
cmake ..

This gets me errors like in my screenshot below. I have played this game with v1.6.0 before, so I'm pretty sure I just need a signature.json for v1.1.0. How invasive would it be to include those signatures in the repo tags? That would save us both some leg work.

whaeck commented 2 years ago

Normally if you do a "fresh" clone (i.e. from scratch), you should not be seeing these issues. These often pop up due to updates to the dependencies and/or the build system when switching versions and/or branches after having cloned NJOY21.

You may want to try removing the NJOY21 folder and try a fresh clone again. I actually tried the exact same commands as you mentioned and I did not get these issues.

herter4171 commented 2 years ago

I have been following the commands I listed, so I've been using fresh clones. The only thing I botched in my description was a cd build before invoking CMake. As far as the platform, we're on Amazon Linux 2, which uses the Yum package manager. On this platform, I can build v1.0.6 only with a signature.json obtained from a third party, and I can build v1.2.2 as-is. From the CMake output, do you have any idea what it's not happy about for v1.1.0?

Output from CMake: