search

njoy / NJOY21

NJOY for the 21st Century
https://www.njoy21.io/NJOY21
Other
74 stars 38 forks source link

Unrecognized routine label from GROUPR #73

Closed jlconlin closed 6 years ago

jlconlin commented 6 years ago

The following input file causes the error:

[error] Unrecognized routine label on line 16
[info] Requested routine: 9228
[info] Error while running NJOY21

This goes through NJOY2016 (although that's no guarantee that it is working as expected.)

moder
 20 -30
moder
 21 -31
groupr
 -30 -31 0 -60                 / Card1
 125 3 3 9 4 1 1 1             / Card2
 "Processing for NJOY class"   / Card3
 293.6                         / Card4
 1E10                          / Card5
 3                             / Card9  #1.1
 0                             / Card9  #1.2
 2631                          / Card10 #1
 3                             / Card 9 #2.1
 0                             / Card 9 #2.2
 9228                          / Card10 #2
 3                             / Card9  #3.1
 0                             / Card9  #3.2
 0                             / Card10 #3
moder
 -60 61
stop
jlconlin commented 6 years ago

By the way, this is the input for the GROUPR2 example in the NJOY class.

jlconlin commented 6 years ago

NJOY21 only looks for one set of Card9s and one set of Card10s, when it should look for several sets of of Card9/Card10.

kahlerac commented 6 years ago

This input looks fine to me. You've got one temperature, per the sixth item on card 2 (and confirmed with only one entry on card 4). Card 9 (#1.1) says to process all file 3 xs's for material 125 at the one and only temperature. Card 9 (#1.2) says we're done with material 125. Card 10 is either zero to signify the end of groupr input or the next material to process. With a non-zero card 10 #2 we then repeat the card 9 sequence. When reaching card 10 #2 its the same scenario ... either zero and groupr's done or non-zero and loop back for more card 9's. We do the latter here and eventually reach card 10 #3 which properly terminates groupr input. If you're crashing in njoy21 when reading card10 #2 I'd say there's an issue with your new input processor --- Skip

jlconlin commented 6 years ago

Thanks @kahlerac for that review. I looked at this at the end of last week and realized that the input parser was not interpreting things correctly. It did not know that’s one could have sets of cards 9 and 10, but assumed, instead, that all card 9s came, the. All card 10s came.

I think I have a fix already implemented; I just have to update the tests to reflect the changes.

kahlerac commented 6 years ago

Hi Jeremy, Actually there can be multiple sets of card 9s before reading a card 10 ... when processing multiple temperatures. See the input for legacy test problem 2. Skip

On Thu, Aug 16, 2018 at 11:01 AM, Jeremy Lloyd Conlin < notifications@github.com> wrote:

Thanks @kahlerac https://github.com/kahlerac for that review. I looked at this at the end of last week and realized that the input parser was not interpreting things correctly. It did not know that’s one could have sets of cards 9 and 10, but assumed, instead, that all card 9s came, the. All card 10s came.

I think I have a fix already implemented; I just have to update the tests to reflect the changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/njoy/NJOY21/issues/73#issuecomment-413576180, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ6USQg_bA_9hpoMn2vYzzSChiJ5uBJuks5uRYlOgaJpZM4V7VvE .

-- Dr. A. C. (Skip) Kahler Kahler Nuclear Data Services, LLC kahler3ac@gmail.com +1 321 368 3645

jlconlin commented 6 years ago

This was fixed in #74