njpipeorgan / wll-interface

Header only C++ library simplifying Wolfram LibraryLink code
MIT License
38 stars 5 forks source link

Suggestions for improvements #3

Closed halirutan closed 4 years ago

halirutan commented 4 years ago

I highly appreciate this project and finally found some time to skim through your code. This PR is not meant for merging but I rather want to point out some things you probably should take a look at.

The only thing I really believe is an oversight on your part is that some of your operator= do not return the this pointer. Others are only suggestions according to clang-tidy:

njpipeorgan commented 4 years ago

Thanks for the suggestions! They all seem good to me.