Fix compatibility with Apple Silicon (M1)

njpipeorgan / wolfram-language-notebook

Notebook support for Wolfram Language in VS Code

Apache License 2.0

159 stars 11 forks source link

Fix compatibility with Apple Silicon (M1) #57

Open min1up opened 10 months ago

min1up commented 10 months ago

Attempts to fix https://github.com/njpipeorgan/wolfram-language-notebook/issues/6

VSCode now properly recognizes and detects Wolfram Kernels on Apple Silicon. Untested with any other platform, so I hope that I haven't made a regression somewhere along the way.

[x] Fix ZeroMQ issues.
[ ] Allow the extension to interact with the Apple Silicon port of Wolfram Mathematica.
[ ] Regression Checks
[ ] Refactoring

Right now, trying to run any code always results in a timeout. I'm not entirely sure why, as every test passes.

njpipeorgan commented 10 months ago

This looks great! I didn't realize that there have been vscode-zeromq prebuilts for quite some time. I'm moving all my refactoring to a development branch, which is not in a usable state, and hope that what's left on the main branch should be working. You might need to rebase to the new main branch.

min1up commented 10 months ago

Wait oops I just woke up, I'm not sure if I'm supposed to do that. I am gonna rebase things now.

njpipeorgan commented 10 months ago

Looks like that it's causing a bit of problem--maybe rebasing to development? Or if you haven't made too many changes, perhaps just copy/paste to the new main. (I really have zero confidence that the refactoring, now on the development branch, is going to work in that way)