njs50 / poe_ext

Path of Exile Inventory Management and Crafting Helper (Chrome Plugin)
http://njs50.github.io/poe_ext/
27 stars 14 forks source link

0.71 #25

Closed spacke closed 12 years ago

spacke commented 12 years ago

(see the forum for a screenshot)

njs50 commented 12 years ago

nice. you might want to move the location thing to under the image.

atm if you click the itemlink (where you hover to get the popover) it does two things:

1) copies the object data to console.log()

2) copies the text version of the item info to the clipboard (as per ctl-c while hovering in game).

that location stuff (and I think you said something about color coding the item data) makes that a bit messy.

I had planned to have a seperate function for rendering the popover item data and the copy to clipboard so you might want to seperate em.

not that it really matters, i'm probalby the only one that knew that worked :p

On Fri, Sep 21, 2012 at 7:13 AM, spacke notifications@github.com wrote:

  • Fixed the properties in the inventory viewer. Properties can now be selected under "Configure Columns".
  • Added a display of the stash/inventory to the popover. It shows the position of the hovered item.

(see the forum for a screenshot)

You can merge this Pull Request by running:

git pull https://github.com/spacke/poe_ext master

Or view, comment on, or merge it at:

https://github.com/njs50/poe_ext/pull/25 Commit Summary

  • merged with upstream
  • - Fixed the properties in the inventory viewer. Properties can now be…
  • fixed update url

File Changes

  • M poe_ext.crx (0)
  • M poe_ext/main.js (45)
  • M poe_ext/manifest.json (4)
  • M poe_ext/myscript.js (17)
  • M poe_updates.xml (6)

Patch Links

spacke commented 12 years ago

Yeah, I saw that it copies the text to the clipboard and yes, it messes it up a lot. ;S Originally I wanted to put the table under the item icon but I needed the feature and didn't want to mess around with the CSS. I will try to separate it in a future version (also the color coding of the elemental damage).