search

njs50 / poe_ext

Path of Exile Inventory Management and Crafting Helper (Chrome Plugin)
http://njs50.github.io/poe_ext/
27 stars 14 forks source link

Added a Select All for the inventory view #33

Closed benjaminjackman closed 11 years ago

benjaminjackman commented 11 years ago

Hi,

I like your extension quite a bit. I had a frequent use case in the inventory panel of wanting to select multiple different categories, so I added a select all button.

If I can sneak some more coding time in before my gf wakes up and keep working on that page. I would like to add calculated dps fields, and also use the cache you setup on top indexeddb to store what boxes are checked for reloads.

Thanks for your time.

njs50 commented 11 years ago

merged it in, will be in the next build.

not sure it's practical for anyone with a lot of junk in their stash. an 'export all data as csv' or something like that option might be better. once ye get twenty+ tabs full of junk rendering that table starts to get a bit slow.

Those 'average damage' calculated fields are all dps i think? not sure what else you'd want. Without looking into all the passives a char has it's pretty hard to do much better. would be nice to be able to do that. parse a players passives to get their +crit chance and +crit damage mods etc.

Just FYI if you do add it to the cache it'll still be cleared on a full refresh, as the full refresh deletes and recreates the db.

benjaminjackman commented 11 years ago

Yeah I just saw the average damage stuff. That's what I was thinking for DPS, so no need for me to work on that.

As for saving data to the cache, now that I can select all so quickly I don't really have a need to do that. I was thinking of maybe making some pre-selected views in the drop down? Like Weapons, Armor things like that, then have the appropriate columns selected and displayed in a nice consistent order.

Thanks for the heads up about full-refreshes, maybe I can make a separate named db that has settings for things like that and have that db stay around between full refreshes if I need to do something like that?

Yeah digging more into the player data to do better calculations would be pretty cool, but pretty challenging as well.

One more change I made was to use container-fluid for body and navbar, I have a rather large monitor and bootstrap was adding alot of margin when using container. Is that ok to do?

On Sun, Feb 3, 2013 at 4:12 PM, Nick Shearer notifications@github.comwrote:

merged it in, will be in the next build.

not sure it's practical for anyone with a lot of junk in their stash. an 'export all data as csv' or something like that option might be better. once ye get twenty+ tabs full of junk rendering that table starts to get a bit slow.

Those 'average damage' calculated fields are all dps i think? not sure what else you'd want. Without looking into all the passives a char has it's pretty hard to do much better. would be nice to be able to do that. parse a players passives to get their +crit chance and +crit damage mods etc.

Just FYI if you do add it to the cache it'll still be cleared on a full refresh, as the full refresh deletes and recreates the db.

— Reply to this email directly or view it on GitHubhttps://github.com/njs50/poe_ext/pull/33#issuecomment-13056392.

njs50 commented 11 years ago

Should be okay. I was thinking about updating bootstrap when 3 comes out. If it isn't out already. I think they drop fluid in it.

Being able to "bookmark" some setups would be nice. You can save data over the full refresh but just need to revalidate it. I.e. some cols may not exist anymore. May not be an issue. Might need a reset everything to defaults option someplace then tho. On Feb 4, 2013 11:28 AM, "benjaminjackman" notifications@github.com wrote:

Yeah I just saw the average damage stuff. That's what I was thinking for DPS, so no need for me to work on that.

As for saving data to the cache, now that I can select all so quickly I don't really have a need to do that. I was thinking of maybe making some pre-selected views in the drop down? Like Weapons, Armor things like that, then have the appropriate columns selected and displayed in a nice consistent order.

Thanks for the heads up about full-refreshes, maybe I can make a separate named db that has settings for things like that and have that db stay around between full refreshes if I need to do something like that?

Yeah digging more into the player data to do better calculations would be pretty cool, but pretty challenging as well.

One more change I made was to use container-fluid for body and navbar, I have a rather large monitor and bootstrap was adding alot of margin when using container. Is that ok to do?

On Sun, Feb 3, 2013 at 4:12 PM, Nick Shearer notifications@github.comwrote:

merged it in, will be in the next build.

not sure it's practical for anyone with a lot of junk in their stash. an 'export all data as csv' or something like that option might be better. once ye get twenty+ tabs full of junk rendering that table starts to get a bit slow.

Those 'average damage' calculated fields are all dps i think? not sure what else you'd want. Without looking into all the passives a char has it's pretty hard to do much better. would be nice to be able to do that. parse a players passives to get their +crit chance and +crit damage mods etc.

Just FYI if you do add it to the cache it'll still be cleared on a full refresh, as the full refresh deletes and recreates the db.

— Reply to this email directly or view it on GitHub< https://github.com/njs50/poe_ext/pull/33#issuecomment-13056392>.

— Reply to this email directly or view it on GitHubhttps://github.com/njs50/poe_ext/pull/33#issuecomment-13056748.