Open Zeracles opened 11 years ago
I had a quick look. looks nice, but it doesn't perform so well with large amounts of items. I think you'll probably need to put in an option to turn off the images. Looks like the col selection is defaulting back to everything whenever the app reloads, which is also an issue with large amounts of items.
As it it was people with >100 stash tabs were already having issues with chrome deciding things were taking too long and shutting down.
Anyways, if you want to sort that out i'm happy to merge it in and push the update for everyone using my autoupdate. I can't change it to update from your crx files as they need to be built/signed with my private key for the autoupdate to work.
Yes, I know should add more options - i'll do that a bit later (when i'm more familiar with the code & have a bit more time :). I've updated to 0.91 with a bunch of requests by my friends - made smaller images & more compact table. As for people with >100 stash tabs - is such problem even solvable in chrome? We'll need a separate SQL for such amounts of data :)
As for your signature - you can easily compress all that folder with your chrome & sign...
probably the best way to deal with the insane amount of stash tabs would be the ability to turn on and off some of the crafting recipes. I think they are what slow things down the most in that case. well, that and not showing images or location data unless someone really wants to see it.
It's been a while since i looked but i think the raw data is probably reparsed every time you load. could probably store the parsed data to speed subsequent loads up.
On Sat, May 18, 2013 at 12:30 PM, Zeracles notifications@github.com wrote:
Yes, I know should add more options. I've updated to 0.91 with a bunch of requests by my friends - made smaller images & more compact table. As for people with >100 stash tabs - is such problem even solvable in chrome? We'll need a separate SQL for such amounts of data :)
— Reply to this email directly or view it on GitHubhttps://github.com/njs50/poe_ext/pull/39#issuecomment-18092265 .
Yes it is reparsed indeed. Location data seems to be loading for every item anyway, also what's with crafting - I haven't looked there yet? Maybe it should be separated into another html file? (Never worked with browser extensions before, but keeping it all in one mail.html file seems to be a little too resource demanding...)
yeah, i never got around from rearranging it from when i picked it up. there's also a bunch of stuff split between files which doesn't make sense :p
having the crafting separated wouldn't be a bad idea. You'll get a million people asking when you're going to fix the chaos recipe, which isn't possible since they don't provide item level data. I get the feeling GGG would shut down the helper if they could.
On Sat, May 18, 2013 at 1:12 PM, Zeracles notifications@github.com wrote:
raw data is probably reparsed every time you load Yes it is reparsed indeed. Location data seems to be loading for every item anyway, also what's with crafting - I haven't looked there yet? Maybe it should be separated into another html file? (Never worked with browser extensions before, but keeping it all in one mail.html file seems to be a little too resource demanding...)
— Reply to this email directly or view it on GitHubhttps://github.com/njs50/poe_ext/pull/39#issuecomment-18093057 .
I have that feeling too, it makes that shiny premium colored tabs with custom names not so useful... On the other hand, GGG seems to be not so commercially oriented as it could (even with that fair play "principle" there are numerous things they could have started selling), so maybe helper will live (at least until they implement some kind of item search of their own...)
What is the chaos reciepe?
one of every slot with item level over 60 something.
On Sat, May 18, 2013 at 9:55 PM, Zeracles notifications@github.com wrote:
What is the chaos reciepe?
— Reply to this email directly or view it on GitHubhttps://github.com/njs50/poe_ext/pull/39#issuecomment-18098152 .
Finished reworking the code, added useful features, like filters... Unfortunately my linux server is down, so I can't update github (don't know how to do it under windows :)
BTW, I never used the "crafting" functionality - PoE Helper was always just a stash search tool for me... Interesting how it used by the majority, though
Ah, And on the screeshot you can see how easy you can have a list of chestplates, that gives you >40 hp, >200 armour, sorted by required level - isn't that the most useful tool ever :)
Looks very nice. I'll see if it copes with my 60 tabs of junk. If so I'll merge it in. Otherwise people with too much junk can stick to my version for now. On May 19, 2013 2:03 AM, "Zeracles" notifications@github.com wrote:
Ah, And on the screeshot you can see how easy you can have a list of chestplates, that gives you >40 hp, >200 armour, sorted by required level - isn't that the most useful tool ever :)
— Reply to this email directly or view it on GitHubhttps://github.com/njs50/poe_ext/pull/39#issuecomment-18101595 .
@Zeracles Also, if you could do a filter-branch and rewrite the names of your commits that would be great. You made a bunch of commits that all have the same title and this doesn't help anyone figure out what you actually did.
Leave the versioning to the maintainer and instead write a description of what the commit actually change.
Is your project still maintained? I made some minor changes (details: http://www.pathofexile.com/forum/view-thread/385603), but more importantly, I want to maintain this one...