search

njsmith / colorspacious

A powerful, accurate, and easy-to-use Python library for doing colorspace conversions
MIT License
169 stars 16 forks source link

Improve CIELab docs #21

Closed maxnoe closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         985    985           
  Branches      124    117    -7     
=====================================
  Hits          985    985

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59e0226...3f18f72. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         985    985           
  Branches      124    123    -1     
=====================================
  Hits          985    985

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59e0226...aa4383e. Read the comment docs.

njsmith commented 5 years ago

@KelSolaar Is L* unbounded too?

KelSolaar commented 5 years ago

Theoretically, it should be! CIE L* was developed for colorimetric measurements of coloured samples under a uniform illumination source however, as you know it, bounding it means data will be destroyed during conversions.

njsmith commented 5 years ago

@KelSolaar ah, good point! thanks

njsmith commented 5 years ago

Thanks!