njsmith / posy

287 stars 17 forks source link

chore: address clippy errors #16

Closed rockstar closed 1 year ago

rockstar commented 1 year ago

This patch addresses the clippy lints that are considered "errors." In the process of addressing clippy::never_loop, I discovered what I think my be a legitimate bug, and believe I've fixed it based on following the the trail of the previous loop, and what the comments describe both bits are supposed to be doing. It will likely need extra scrutiny, as it's not just a lint change, but potentially changing the logic flow.

Fixes #15

njsmith commented 1 year ago

First two commits look great! For the last commit, I think we want what I wrote in #15 instead?

rockstar commented 1 year ago

@njsmith addressed your issues (sorry for the delay).

njsmith commented 1 year ago

Thanks!