njsmith / posy

289 stars 17 forks source link

product version fails on osx 12.5 #5

Closed davidszotten closed 1 year ago

davidszotten commented 1 year ago

on osx 12.5 my version string is reported as [src/platform_tags/macos.rs:94] &product_version_str = "12.5\0"

making the assertion just below fail assert!(pieces.len() == 3);

maccam912 commented 1 year ago

Same on 13.1, considering https://github.com/njsmith/posy/blob/1cfd7abb3893478dfa37704b310529c85cadc2b3/src/platform_tags/macos.rs#L102 throws out the last part anyway, it seems like the last piece could just be an optional? This is assuming there are macos versions that DO return 3 pieces.