search

njtierney / geotargets

Targets extensions for geospatial data
https://njtierney.github.io/geotargets/
Other
49 stars 4 forks source link

Add geotargets options functions, with defaults for raster GDAL driver and creation options #19

Closed brownag closed 3 months ago

brownag commented 4 months ago

Two new draft functions were added for #16 : geotargets_option_get() and geotargets_option_set().

I noticed that the code coverage was failing. There seems to be an issue with modifying the function body for create_format_terra_raster() inside covr::package_coverage(). This PR fixes that.

It appears coverage issue can be resolved by allowing for the default options for GDAL driver (filetype) and creation options (gdal) to be used in the template function, rather than NULL. Though I am still curious what is happening inside the evaluation {covr} does that causes this to fail.

njtierney commented 4 months ago

Also thank you so much for catching that {covr} error - I had just chalked it up to "CI be weird sometimes" and shelved it for later. This is a huge help!