search

njtierney / geotargets

Targets extensions for geospatial data
https://njtierney.github.io/geotargets/
Other
49 stars 4 forks source link

Add filetype argument to `tar_terra_vect()` #21

Closed Aariq closed 3 months ago

Aariq commented 3 months ago

I tried to replicate additions to tar_terra_rast() in tar_terra_vect(). I think ESRI Shapfiles need special handling, and potentially other formats won't work. I made the default format GeoJSON simply because it is an included driver and produces a single file.

Aariq commented 3 months ago

Not quite working yet. Somewhere I've not defined the object gdal. Can investigate tomorrow

njtierney commented 3 months ago

I perhaps wonder if once #19 is merged and this is rebased/merged off of that if it will help resolve some of those changes?

njtierney commented 3 months ago

It passes checks! Did you want to merge now?

Aariq commented 3 months ago

If you'd rather merge #19 first, I can update this PR to use default options for filetype. Or we can merge them both and do that in a separate PR. Doesn't matter to me.

njtierney commented 3 months ago

I think I'd prefer to merge #19 first actually - there are a couple of changes that you requested, I'll comment on them in the PR - but maybe these could be addressed in separate issues.