geotargets options / defaults update

njtierney / geotargets

Targets extensions for geospatial data

https://njtierney.github.io/geotargets/

Other

49 stars 4 forks source link

geotargets options / defaults update #30

Closed brownag closed 3 months ago

brownag commented 3 months ago

Some updates to options following #19 for #26

Adds vector data analogs for options introduced in #19, can be used for #21
Updates "driver name" options to remove _NAME/_name suffix for #25
Other cleanup: fix some option names not updated in #19, only specify default arguments once (in geotargets_option_get(), add geotargets_repair_option_name()

njtierney commented 3 months ago

Really nice work! I believe this resolves #25 #26 ?

It looks like it handles all we need for those issues to me. We can come back to #27 in a separate PR I think. Are you happy for me to merge?

brownag commented 3 months ago

Really nice work! I believe this resolves #25 #26 ?

It looks like it handles all we need for those issues to me. We can come back to #27 in a separate PR I think. Are you happy for me to merge?

Thanks. Last thing was I realized that ENCODING as a default creation option for GTiff doesn't make sense... that is the default for terra::writeVector() but few or no raster drivers support it anyway. Should be good to merge if you are happy with it

njtierney commented 3 months ago

Yup! Awesome 🚀