njtierney / maxcovr

Tools in R to make it easier to solve the Maximal Coverage Location Problem
http://maxcovr.njtierney.com/
GNU General Public License v3.0
43 stars 12 forks source link

Should max_coverage_relocation be inside max_coverage? #32

Closed njtierney closed 6 years ago

njtierney commented 7 years ago

Currently they are two separate functions: max_coverage_relocation and max_coverage.

They have slightly different options, in particular max_coverage_relocation has costs rather than a specified number of AEDs to add.

Not sure if there is a standard here, but just a thought. I'd prefer to keep the functions as simple as possible.

njtierney commented 6 years ago

Closing this as I want to embrace functional programming as much as possible - so I am in favour of different functions for different tasks.