search

njtierney / maxcovr

Tools in R to make it easier to solve the Maximal Coverage Location Problem
https://njtierney.github.io/maxcovr/
GNU General Public License v3.0
43 stars 12 forks source link

namespace in max_coverage #65

Closed carbonmetrics closed 6 years ago

carbonmetrics commented 6 years ago

max_coverage does not run without loading dplyr. max_coverage contains function extract_mc_results in line 156, and that function calls bind_rows in line 45 - I guess dplyr::bind_rows would solve the issue.

as an aside - why did you implement this in dplyr? data.table is much faster.

njtierney commented 6 years ago

Hello!

Thank you for picking up on the namespace issue! This has now been fixed.

I am interested in making maxcovr faster in the future, data.table will be considered at a later release (#68), but for the moment there are other changes that I would like to make. I would welcome a PR for using data.table if you are interested