search

njtierney / naniar

Tidy data structures, summaries, and visualisations for missing data
http://naniar.njtierney.com/
Other
650 stars 54 forks source link

Fixes for dplyr 1.0.0 #253

Closed hadley closed 4 years ago

hadley commented 4 years ago

No real big changes here — just one failing test because all.equal.tbl_df used to ignore column order.

But I also eliminate a bunch of warnings, mostly by coercing to tibble before binding, instead of after. I think this is generally more principled, and it certainly generates fewer warnings with dev vctrs.

njtierney commented 4 years ago

Thanks, Hadley! Really appreciate you taking the time. Changes make sense, and good to know about the idea of coercing to tibble before binding.