search

njuhugn / leveldb

Automatically exported from code.google.com/p/leveldb
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Merge patches from Fedora RPM #181

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

The Fedora package for leveldb includes a few useful patches.

Please provide any additional information below.

leveldb-0001-Initial-commit-of-the-autotools-stuff.patch
leveldb-0002-Add-memory-barrier-on-PowerPC.patch
leveldb-0003-bloom_test-failure-on-big-endian-archs.patch
leveldb-0004-leveldbjni.patch

More Fedora bits here:

http://koji.fedoraproject.org/koji/packageinfo?packageID=14292

http://pkgs.fedoraproject.org/cgit/leveldb.git/

Original issue reported on code.google.com by fullung@gmail.com on 27 Jun 2013 at 8:03

Attachments:

GoogleCodeExporter commented 9 years ago 
Right, it seems the memory barrier one has some history in issue 102. I'm 
guessing the patch works for all the Fedora archs, even though issue 102 raises 
some objections about it for Alpha.

The bloom_test failure patch is trivial. I contacted the author. No word yet.

The leveldbjni one is relatively trivial, but it's not clear who the author was.

The autotools one doesn't have to go in.

Original comment by fullung@gmail.com on 28 Jun 2013 at 4:02

GoogleCodeExporter commented 9 years ago 
I was the author of the leveldbjni patch. Basically, the JNI layer needs to be 
able to access the data_ size_ fields of a Slice to be able to copy Java data 
in and out of Slices.

The JNI library also links in leveldb as a static library into the jni shared 
library.  So, it needs that static library to be built with -fPIC and that's 
the reason for the changes to build_detect_platform.

Original comment by chir...@gmail.com on 28 Jun 2013 at 12:37