make the scripts optional as part of an extra

njzjz / nodejs-wheel

Unoffical Node.js wheels, `pip install nodejs-wheel`

https://pypi.org/project/nodejs-wheel/

MIT License

8 stars 5 forks source link

make the scripts optional as part of an extra #23

Closed DetachHead closed 7 months ago

DetachHead commented 7 months ago

i'm considering switching to this project from nodejs-bin. it makes the node, npm and npx scripts optional and only installs them if you install the cmd extra:

pip install 'nodejs-bin[cmd]'

that's useful in my case because i only need to call node programmatically and not via the command line, and i'd prefer users of my package to not unknowingly have a node binary added to their path.

njzjz commented 7 months ago

We may have two options to do it (like https://github.com/scikit-build/cmake-python-distributions/issues/80#issuecomment-502787361). One is

nodejs-wheel[cmd]
nodejs-wheel

Another one is

nodejs-wheel
nodejs-wheel-binaries (nodejs-wheel is based on nodejs-wheel-binaries)

I prefer the second one, as it has no breaking change to nodejs-wheel.