fix some issues with the types

[DetachHead]

• fix type error when the return_completed_process argument isn't specified, which was causing it to resolve to the wrong overload:

  exit_code: int = node(["foo"]) # error: Expression of type "int | CompletedProcess[str | bytes]" is incompatible with declared type "int"

• change the type of args to Iterable[str] instead of list[str], which is more flexible. for example, when wrapping it with a function that passes it a tuple:

  def run_node(*args: str)
    node(args) # error: Argument of type "tuple[str, ...]" cannot be assigned to parameter "args" of type "list[str] | None"

[pep8speaks]

Hello @DetachHead! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file nodejs_wheel/executable.py:

Line 83:80: E501 line too long (86 > 79 characters) Line 132:80: E501 line too long (86 > 79 characters) Line 186:80: E501 line too long (86 > 79 characters)

Comment last updated at 2024-05-13 09:11:56 UTC