njzjz / wenxian

A tool to generate BibTeX files from given identifiers (DOI, PMID, or arXiv ID).
https://wenxian.njzjz.win/
GNU Lesser General Public License v3.0
3 stars 0 forks source link

fix: volume, issue, and pages may not be digits #35

Closed njzjz closed 3 days ago

njzjz commented 3 days ago

For example, the page of https://doi.org/10.1103/PhysRevB.108.L180104 is not a number.

pep8speaks commented 3 days ago

Hello @njzjz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:80: E501 line too long (84 > 79 characters)

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.97%. Comparing base (a4a5a90) to head (b7d6274).

Files Patch % Lines
wenxian/feeder/feeder.py 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #35 +/- ## ========================================== - Coverage 90.97% 90.97% -0.01% ========================================== Files 12 12 Lines 399 410 +11 ========================================== + Hits 363 373 +10 - Misses 36 37 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.