nk2028 / tshet-uinh-examples

JavaScript examples to generate the derivatives of the Qieyun system using TshetUinh.js
https://www.npmjs.com/package/qieyun-examples
Creative Commons Zero v1.0 Universal
42 stars 14 forks source link

Add decorated Kan-on romanization #56

Open justinsilvestre opened 9 months ago

justinsilvestre commented 9 months ago

Hi 👋

I have a Middle Chinese notation system a little like ayaka's "綾香思考音系". I think it would be nice to add it to the qieyun autoderiver, if possible.

graphemecluster commented 9 months ago

@syimyuzya @untunt Wanna review before merging?

justinsilvestre commented 9 months ago

The question is, why this should be included in qieyun-examples?

Not sure who you're asking 😅 but maybe it would be a good idea to formalize some "criteria for inclusion" and document them here in this repo. I just saw there were a few other obscure Middle Chinese notations here, so I figured one more would be welcome.

(It IS a great notation system IMO though, for indroduction of Middle Chinese for those familiar with Kan-on)

Thanks 😊

To me, the schemes are alreay too many for us to maintain in this single repo, and there has been plans to drop support for most of them on the next update of Qieyun.js (if any soon 🙈).

Fair enough. If it helps, I can make sure to handle any necessary updates to this file in the event or a Qieyun.js update.

syimyuzya commented 9 months ago

maybe it would be a good idea to formalize some "criteria for inclusion" and document them

If that's gonna be the case, it will probably be "TUPA and reconstructions of MC or Old Mandarin only" (not even Polyhedron's romanization would make it) :joy:

justinsilvestre commented 1 week ago

For my own use, I updated this code for the new version of the library, and tested in on the https://nk2028.shn.hk/tshet-uinh-autoderiver/ site.

I'm not sure if there's a chance of this getting merged, but since the PR has been open this whole time, I thought, why not update the PR with the new code and see what happens 😛 Cheers!