search

nkalupahana / baseline

Take charge of your mental health with better journaling and mood tracking.
https://getbaseline.app
GNU Affero General Public License v3.0
53 stars 13 forks source link

Missing data is treated as 0 instead of N/A in mood graph #324

Closed MicahRus closed 10 months ago

MicahRus commented 10 months ago

This may be more of a discussion than an issue. But to me it doesn't make sense for missing data in the mood graph to be filled as 0. This creates weird looking data when failing to track mood for even just 1 day but more importantly it isn't a true reflection on my mood for that day.

I would suggest to treat missing data as N/A. I would also suggest to have some indication on the graph of when it is missing data (Grayed out, different colour, different pattern, etc)

nkalupahana commented 10 months ago

I'm sorry, I'm not sure I understand. On the mood graph, when you log a 0, you get a blue dot on the center line. When you don't log anything, there's nothing there (no dots at all). That's different, right? More clarification would be great, thanks.

MicahRus commented 10 months ago

Hopefully these images can help clarify what I'm talking about.

To me it seems like missing days, the data is being set to 0. Whereas i think it would be more correct to mark the data as n/a. Screenshot_20240106_221958_baseline Screenshot_20240106_221947_baseline Screenshot_20240106_221857_baseline

As you can see in the images I have no entries from the 9th of September onwards, but the data is reflecting those days as being a 0. Where I think they should be ungraded as it makes the mood look worse or better than it was.

nkalupahana commented 10 months ago

Oh, yes! Good news -- this was fixed in a PR last week and is currently in beta. Expect the fix to be rolled out soon.