nkanaev / yarr

yet another rss reader
MIT License
3.04k stars 224 forks source link

RSS: `<guid isPermalink=“true”>` isn’t being taken as the URL #143

Closed adaszko closed 1 year ago

adaszko commented 1 year ago

Hi!

This particular feed: https://huggingface.co/blog/feed.xml is missing the <link> element but according to specs, it is enough to set <guid isPermalink=“true”> and specify URL there. yarr doesn’t seem to be doing it as the article don’t “open” for me. Instead, the browser just re-opens yarr in a new tab.

Context: https://github.com/huggingface/blog/issues/42#issuecomment-1554080984

nkanaev commented 1 year ago

thanks for the report! fixed in https://github.com/nkanaev/yarr/commit/bc18557820ed7c2d137b3ebadd7dfdf599d725cc

adaszko commented 1 year ago

Awesome, thanks as well!

julien-c commented 1 year ago

that's awesome!