search

nkbt / component-router

Redux-based component routing solution
https://nkbt.github.io/component-router
MIT License
93 stars 7 forks source link

Add redux #68

Closed halhenke closed 9 years ago

halhenke commented 9 years ago

Re #68: Hope this is OK. Copied across the addThrottledChangeListener function from the flux-common-store package. Didnt use react-redux bindings - not sure if you want to add those in?

nkbt commented 9 years ago

Looks great (at least what I can tell looking to my phonee) will try it later from the laptop.

nkbt commented 9 years ago

Href in urls is not changed according to Location type. Using html4 (hash) - try to open any link in new tab (or just look at the href itself) - it is not using hash, but is just a normal link.

nkbt commented 9 years ago

And a little bit more tests for Store would be great https://circle-artifacts.com/gh/in-flux/component-router/142/artifacts/0/tmp/circle-artifacts.3LEItO4/coverage/src/Store.js.html

nkbt commented 9 years ago

Rest looks pretty awesome to me, thanks a lot!

halhenke commented 9 years ago

Thanks! :smile:

Will make changes and update, hopefully later tonight.

halhenke commented 9 years ago

Added missing tests for Store functions. HTML4 seems to be working again after 162e3f5d98ac8481e68ab4022339648abfd61540

nkbt commented 9 years ago

I see, great! Knew it must be something like a typo.