WIP: Feature/flux only examples

nkbt / component-router

Redux-based component routing solution

https://nkbt.github.io/component-router

MIT License

93 stars 7 forks source link

WIP: Feature/flux only examples #73

Closed halhenke closed 9 years ago

halhenke commented 9 years ago

Not sure if this is what you have in mind - basically have 2 examples on the same page. One that doesnt use <ComponentRouter> but still uses <Url> and another that just uses ordinary links. They both behave the same and are dealing with the same state so theres no difference without looking at the implementation but I suppose thats not a bad thing to show. Anyway let me know if this is on the right track and what needs changing.

halhenke commented 9 years ago

Hope you are having a good time in Cambodia btw - a holiday?

nkbt commented 9 years ago

@halhenke what's the status of this one?

halhenke commented 9 years ago

ah sorry - didnt notice you had added notes until now :-(

will make changes & push tonight

nkbt commented 9 years ago

Awesome! Don't forget to rebase, since I've added heaps of changes today. And will publish 3.0 (2.2.1 was kind of broken in terms of compatibility due to redux and different API for stores/actions, had to release 3.0 instead)

halhenke commented 9 years ago

Cool - haven't had a chance to catch up with the changes properly yet or look at Redux v3. Maybe its my imagination but performance feels a little smoother. Anyway exciting to be at v3!

nkbt commented 9 years ago

The only thing I found missing - removing added param on componentWillUnmount, see 34490522454d9e7da2dc00960d80b3d95c027998

And I changed the name to switchBlock, since switch is reserved word.

I could not find why github diff is broken though =(

halhenke commented 9 years ago

:+1:

nkbt commented 9 years ago

Thanks a lot, great work!