search

nkbt / react-collapse

Component-wrapper for collapse animation with react-motion for elements with variable (and dynamic) height
MIT License
1.13k stars 113 forks source link

Conflict with CSSTransitionGroup #180

Closed jonom closed 5 years ago

jonom commented 7 years ago

I noticed that if you have a Collapse component anywhere inside a CSSTransitionGroup, and isOpened=true when the Collapse element is mounted, the parent container of the Collapse item that is entering the CSSTransitionGroup doesn't play it's transition animation. The container receives all the right classes but it's as if it receives the active class at the same time as the other classes, so no change is recognised by the browser and the transition doesn't kick in.

Don't know if the cause is within the Collapse component or the CSSTransitionGroup but thought I would flag it... of course feel free to close this if you think it's out of scope.

Thanks for this handy component!

nkbt commented 7 years ago

I don't work with CSSTransitionGroup and don't have any plans to, so cannot help unfortunately

nkbt commented 5 years ago

As new react-collapse@5.0.0 is released https://github.com/nkbt/react-collapse/releases/tag/v5.0.0 this issue has been most likely already solved.

Please feel free to re-open if the issue persists