Fix UnmountClosed for new React

nkbt / react-collapse

Component-wrapper for collapse animation with react-motion for elements with variable (and dynamic) height

MIT License

1.12k stars 113 forks source link

Fix UnmountClosed for new React #249

Closed nkbt closed 4 years ago

nkbt commented 4 years ago

In newer versions of React getDerivedStateFromProps was called on any update even if props haven't changed. Replacing it with componentDidUpdate fix the issue of never getting into isResting state

nkbt commented 4 years ago

Published to http://nkbt.github.io/react-collapse/ with the latest fix, working well