Fix #86 and #62: handle 0 as default value

nkbt / react-debounce-input

React component that renders Input with debounced onChange

MIT License

450 stars 61 forks source link

Fix #86 and #62: handle 0 as default value #125

Closed Thiht closed 3 years ago

Thiht commented 3 years ago

Fix #86 and #62

Before fix:

After fix:

Note: I also gave it a try with the ?? operator but got the following error:

SyntaxError: /Users/thiht/workspace/react-debounce-input/src/Component.js: Support for the experimental syntax 'nullishCoalescingOperator' isn't currently enabled

so I just went with the less fancy solution instead

nkbt commented 3 years ago

Well, good news CI still works ¯_(ツ)_/¯

Thiht commented 3 years ago

Can you merge or is there any remaining blocking point ? :)

nkbt commented 3 years ago

CI check fails because of lint errors in this change, so I was waiting for that fix.

Thiht commented 3 years ago

oh sorry I didn't see it was from the component I added, I thought it was already red before! Will fix this evening.

Thiht commented 3 years ago

fixed

nkbt commented 3 years ago

Thiht commented 3 years ago

Thanks :+1:

nkbt commented 3 years ago

Thank you 🙏