search

nkbt / react-height

Component-wrapper to determine and report children elements height
MIT License
180 stars 27 forks source link

Refactored to use es6 classes #29

Closed Andarist closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #29 into master will decrease coverage by 9%. The diff coverage is 66.66%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #29   +/-   ##
====================================
- Coverage      25%   16%   -9%     
====================================
  Files           1     1           
  Lines          28    25    -3     
====================================
- Hits            7     4    -3     
  Misses         21    21
Impacted Files Coverage Δ
src/ReactHeight.js 16% <66.66%> (-9%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f98d84b...e33a3ba. Read the comment docs.

Andarist commented 7 years ago

please look carefully and check if i didnt miss anything, could have happened, as ive done it manually, but i think its fine

nkbt commented 7 years ago

Thanks. I'll check tomorrow. It's night here in Sydney now...