search

nkbt / react-height

Component-wrapper to determine and report children elements height
MIT License
180 stars 27 forks source link

fix for react 16 #33

Closed bentatum closed 3 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #33   +/-   ##
====================================
  Coverage      16%   16%           
====================================
  Files           1     1           
  Lines          25    25           
====================================
  Hits            4     4           
  Misses         21    21
Impacted Files Coverage Δ
src/ReactHeight.js 16% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63a13a9...1f4e89a. Read the comment docs.

bentatum commented 6 years ago

Happy to fix the what's breaking here with your CI. Not sure how though, just add a unit test for this?

nkbt commented 6 years ago

Ignore codecov and appveyor. Need to remove them anyway... Any insight on why this PR and what was the problem?