search

nkbt / react-height

Component-wrapper to determine and report children elements height
MIT License
180 stars 27 forks source link

Update prop-types to 15.5.10 #37

Closed leonidsheremeto closed 6 years ago

leonidsheremeto commented 6 years ago

Hello.

Using your library we have a warning "Calling PropTypes validators directly is not supported by the prop-types"

This question has already been discussed here: https://github.com/malte-wessel/react-custom-scrollbars/issues/153 and people advice to update prop-types to 15.5.10

Thank you.

codecov[bot] commented 6 years ago

Codecov Report

Merging #37 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #37   +/-   ##
====================================
  Coverage      16%   16%           
====================================
  Files           1     1           
  Lines          25    25           
====================================
  Hits            4     4           
  Misses         21    21

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63a13a9...d941a1d. Read the comment docs.

LeoIannacone commented 6 years ago

Hi, can you please merge this ?

Ektoplasme commented 5 years ago

Still on 15.5.8 too